Skip to content

Improve pointer arithmetic docs #83579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2021
Merged

Improve pointer arithmetic docs #83579

merged 2 commits into from
Mar 30, 2021

Conversation

RalfJung
Copy link
Member

  • Add slightly more detailed definition of "allocated object" to the module docs, and link it from everywhere.
  • Clarify the "remains attached" wording a bit (at least I hope this is clearer).
  • Remove the sentence about using integer arithmetic; this seems to confuse people even if it is technically correct.

As usual, the edit needs to be done in a dozen places to remain consistent, I hope I got them all.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2021
dtolnay
dtolnay approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@dtolnay
Copy link
Member

dtolnay commented Mar 30, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2021

📌 Commit 4f03f94 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2021
@bors
Auto merge of rust-lang#83674 - Dylan-DPC:rollup-bcuc1hl, r=Dylan-DPC
16156fb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#83568 (update comment at MaybeUninit::uninit_array)
 - rust-lang#83571 (Constantify some slice methods)
 - rust-lang#83579 (Improve pointer arithmetic docs)
 - rust-lang#83645 (Wrap non-pre code blocks)
 - rust-lang#83656 (Add a regression test for issue-82865)
 - rust-lang#83662 (Update books)
 - rust-lang#83667 (Suggest box/pin/arc ing receiver on method calls)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b67543 into rust-lang:master Mar 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 30, 2021
@RalfJung RalfJung deleted the ptr-arithmetic branch April 6, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

+1 more reviewer

@danielhenrymantilla danielhenrymantilla danielhenrymantilla approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rust-highfive @dtolnay @bors @danielhenrymantilla @rustbot